chaokunyang commented on code in PR #2532:
URL: https://github.com/apache/fory/pull/2532#discussion_r2302696687
##########
ci/deploy.sh:
##########
@@ -85,6 +85,21 @@ build_pyfory() {
else
$PYTHON_CMD setup.py bdist_wheel --dist-dir="$ROOT/dist"
fi
+ elif [[ "$OSTYPE" == "msys" || "$OSTYPE" == "win32" ]]; then
+
+ if [ -n "$GITHUB_REF_NAME" ]; then
+ # Strip leading 'v' if present
+ version="${GITHUB_REF_NAME#v}"
+ echo "Using version from GITHUB_REF_NAME: $version"
+
+ # Windows tends to drop alpha/beta markers - force it through setup.cfg
Review Comment:
We don;t have this for v0.12.0, but hte released wheels for windows are
right:
<img width="860" height="136" alt="image"
src="https://github.com/user-attachments/assets/e0196122-c283-4398-aeed-97380622a21f";
/>
https://test.pypi.org/project/pyfory/0.12.0a2/#files
The version are read from :
```
[tool.setuptools.dynamic]
version = {attr = "pyfory.__version__"}
```
And it's set in `ci/release.py`:
```python
def _update_python_version(lines, v: str):
for index, line in enumerate(lines):
if "__version__ = " in line:
v = v.replace("-alpha", "a")
v = v.replace("-beta", "b")
v = v.replace("-rc", "rc")
lines[index] = f'__version__ = "{v}"\n'
break
```
Could you check whether you set this version right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
