zhztheplayer commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1989773812
> Thank you @zhztheplayer for the improvement. I'm wondering why we need to make our transformer plan inherit spark operator. Is there any history reason ? Yes it was mainly because of historical reasons of this project. We used to have different backgrounds of developers with various knowledge on Scala at the very first launching phase of this project. > Is it possible that just pass spark operator to transformer plan as a parameter ? For example, like the comet: [CometScanExec](https://github.com/apache/arrow-datafusion-comet/blob/main/spark/src/main/scala/org/apache/spark/sql/comet/CometScanExec.scala) That looks like a good idea and we may need to check if it's feasible to use that approach for Gluten too. Probably it can be done in shim layer without altering too much core module code. Although it may require for considerable refactor work. Once doing that, we can just remove the pasted files from this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
