Yohahaha commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1991055517
> However it's not about directly overriding the same class with same name in Gluten which may lead to a bunch of problems like class loadings. Are we aligned here? yes, I'm not going to blocking this PR, shim layer always complex, but copy source code is risky and hard to maintain, hope we can keep iterating shim layer more clean, thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
