zhztheplayer commented on code in PR #4893:
URL: https://github.com/apache/incubator-gluten/pull/4893#discussion_r1520852289
##########
gluten-ut/spark33/src/test/scala/io/glutenproject/utils/clickhouse/ClickHouseTestSettings.scala:
##########
@@ -339,6 +339,10 @@ class ClickHouseTestSettings extends BackendTestSettings {
.exclude("Option recursiveFileLookup: disable partition inferring")
.exclude("SPARK-31116: Select nested schema with case insensitive mode")
.exclude("SPARK-35669: special char in CSV header with filter pushdown")
+ // DISABLED: GLUTEN-4893 Vanilla UT checks scan operator by exactly
matching the class type
+ .exclude("File source v2: support passing data filters to FileScan without
partitionFilters")
+ // DISABLED: GLUTEN-4893 Vanilla UT checks scan operator by exactly
matching the class type
+ .exclude("File source v2: support partition pruning")
Review Comment:
@zzcclp
I am disabling some UTs (including CH ones) that are based on strict type
checking of the scan plan. We'd fix them case by case in later PRs but probably
by pasting Spark's code to our UT folder. Or there might be better solutions,
we can keep thinking of it. At this time it's more important to have the case
class inheritance issue corrected, I don't have enough resource to do
everything in one patch. So would that work for you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
