zhztheplayer commented on PR #4893: URL: https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1991040313
> I believe the way below is better than copy more and more Spark source files into Gluten. In case of ambiguity, the files are pasted to Gluten with 'Abstract' prefix so it should not have any class type conflictions with vanilla Spark. I understood your point based on this assumption: If one changes vanilla Spark's `FileSourceScanExec`, then Gluten's `FileSourceScanExecTransformer` works fine with it before, then it may not work after this patch since Gluten now uses unmodified code from Vanilla Spark. That may be considered a backward-compatibility issue. However it's not about directly overriding the same class with same name in Gluten which may lead to a bunch of problems like class loadings. Are we aligned here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
