Yohahaha commented on PR #4893:
URL: 
https://github.com/apache/incubator-gluten/pull/4893#issuecomment-1991044848

   > > f user has modified these source file in their own Spark
   > 
   > Thanks for the comment here. It sounds like a very valid use case we 
should consider about. Do you already know some people are doing things with 
this way, especially changing Spark scan's code? That may drive us to migrate 
to the other solution as soon as possible.
   
   I'm not sure others' way, we maintain an internal branch of vanilla spark 
with lots of changes, but not change scan's interface, so I guess this PR may 
not introduce conflicts but not verified yet. 
   
   We found conflicts before, when ParquetFileFormat was copied in spark33. So, 
copy vanilla spark's source file into Gluten is a risky way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to