Yifeng-Wang commented on PR #9107: URL: https://github.com/apache/incubator-gluten/pull/9107#issuecomment-2754049025
Hi @jinchengchenghh I have several findings and would like to check with you, please correct me if Im wrong. 1. I located the functions are now causing errors with info "Unknown function parser" for clickhouse BE in the CI test.  2. I referenced previous code which added support staticInvoke calling url_encode/decode functions, where, URL_DECODE/URL_ENCODE were added to CH_BLACKLIST_SCALAR_FUNCTION(CHExpressionUtil.scala) to make `CHValidatorApi::doExprValidate` return `false`(CHValidatorApi). That said, the staticInvoke branch will early return the Transformer, in advance gluten validation: (main br line 151) case i: StaticInvoke => .... (main br line 171)`val substraitExprName: String = getAndCheckSubstraitName(expr, expressionsMap)` Is this as expected? or should we, make it a work around, jus swap the two branchings' positions in code so that we make use of that black list? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
