Yifeng-Wang commented on PR #9107:
URL:
https://github.com/apache/incubator-gluten/pull/9107#issuecomment-2757939808
> Just add the new functions name to CH_BLACKLIST_SCALAR_FUNCTION like
URL_DECODE
Hi @jinchengchenghh some new findings,
1. **[Error reprod]** env: gluten clickhouse (main branch) + Spark3.5.2. The
other StaticInvokes url_decode/url_decode also **fail** e.g. :
`INSERT INTO url_tbl VALUES ('https://spark.apache.org');`
`SELECT url_encode(a) AS encoded_url FROM url_tbl; `
*org.apache.gluten.exception.GlutenException: Unknown function parser
url_decode*
2. **[Problem]** As I mentioned in my previous comment, the
ExpressionTransfomer for staticInvoke calls in current main br code
(ExpressionConverter.scala line151) should not return in advance of function
checks.
3. **[Possible Solution]** Velox and CH backends exhibit diffs in their
ValidatorAPI implementations, particularly in
`doNativeValidateWithFailureReason` and `doExprValidate`.
- `doExprValidate`: Velox BE->always true; CH BE-> go through some
blacklists, e.g.
- `doNativeValidateWithFailureReason`: Velox BE-> validate at native; CH BE
-> not supp.
Can we for now intercept unsupp staticInvoke functions for CH at
`replaceStaticInvokeWithExpressionTransformer` with an extra
ValidatorApi::doExprValidate (so that CH_BLACKLIST_SCALAR_FUNCTION can serve
purpose)? : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
