cc5566 commented on code in PR #9779:
URL: https://github.com/apache/gravitino/pull/9779#discussion_r2747307539
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -475,7 +475,10 @@ private Configs() {}
public static final ConfigEntry<String>
PARTITION_STATS_STORAGE_FACTORY_CLASS =
new ConfigBuilder("gravitino.stats.partition.storageFactoryClass")
- .doc("The partition stats storage factory class.")
+ .doc(
+ "The partition stats storage factory class. "
+ + "Default is Lance-based storage. "
+ + "For production use, configure
JdbcPartitionStatisticStorageFactory with database settings.")
.version(ConfigConstants.VERSION_1_0_0)
.stringConf()
.createWithDefault(LancePartitionStatisticStorageFactory.class.getCanonicalName());
Review Comment:
Changing the default storage would break configurations without JDBC
settings, as JdbcPartitionStatisticStorageFactory requires mandatory jdbc
parameters in validateRequiredProperties. Users may have to provide JDBC
config to start Gravitino .
Keeping lance as the default storage would skip the mandatory configuration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
