cc5566 commented on PR #9779:
URL: https://github.com/apache/gravitino/pull/9779#issuecomment-3829300594
@jerqi Thanks for the review! I've addressed all the feedback in the latest
commit:
1. ✅ **Issue linking**: Created issue #9838 and updated PR title to `[#9838]
feat(storage): Add JDBC storage backend for partition statistics`
2. ✅ **Upgrade scripts**: Added `partition_statistic_meta` table creation to:
- `upgrade-1.1.0-to-1.2.0-mysql.sql`
- `upgrade-1.1.0-to-1.2.0-postgresql.sql`
- `upgrade-1.1.0-to-1.2.0-h2.sql`
3. ✅ **Default storage**: Made JDBC the default partition statistics storage
backend
- Changed default from `LancePartitionStatisticStorageFactory` to
`JdbcPartitionStatisticStorageFactory`
- Implemented automatic reuse of entity store JDBC properties as defaults
(jdbcUrl, jdbcDriver, jdbcUser, jdbcPassword, poolMaxSize, connectionTimeoutMs)
- Partition-specific configs
(`gravitino.stats.partition.storageOption.*`) can still override these defaults
4. ✅ **Code style**: Refactored `setPartitionRangeParameters()` to use
`ifPresent()` instead of `isPresent()` + `get()`
All tests pass successfully. Ready for another review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
