cc5566 commented on code in PR #9779:
URL: https://github.com/apache/gravitino/pull/9779#discussion_r2756146167
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -475,8 +475,11 @@ private Configs() {}
public static final ConfigEntry<String>
PARTITION_STATS_STORAGE_FACTORY_CLASS =
new ConfigBuilder("gravitino.stats.partition.storageFactoryClass")
- .doc("The partition stats storage factory class.")
+ .doc(
+ "The partition stats storage factory class. "
+ + "Default is JDBC-based storage using the same database as
entity storage. "
Review Comment:
Changing the default storage to JDBC would break configurations without JDBC
settings, as JdbcPartitionStatisticStorageFactory requires mandatory jdbc
parameters in validateRequiredProperties. Users may have to provide JDBC config
to start Gravitino .
In this case, since the entity store usually uses the JDBC as the storage,
we just reuse the entity store JDBC parameters as the default value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
