yuqi1129 commented on code in PR #9779:
URL: https://github.com/apache/gravitino/pull/9779#discussion_r2753322574
##########
core/src/main/java/org/apache/gravitino/Configs.java:
##########
@@ -475,8 +475,11 @@ private Configs() {}
public static final ConfigEntry<String>
PARTITION_STATS_STORAGE_FACTORY_CLASS =
new ConfigBuilder("gravitino.stats.partition.storageFactoryClass")
- .doc("The partition stats storage factory class.")
+ .doc(
+ "The partition stats storage factory class. "
+ + "Default is JDBC-based storage using the same database as
entity storage. "
Review Comment:
> using the same database as entity storage
I have something unclear about this point. Is it to say that once
`gravitino.stats.partition.storageOption.jdbcUrl` is not set, we will use the
value of the entity store URL to store statistics data?
##########
docs/manage-statistics-in-gravitino.md:
##########
@@ -258,7 +320,14 @@ For Lance remote storage, you can refer to the document
[here](https://lancedb.g
If you have many tables with a small number of partitions, you should set a
smaller metadataFileCacheSizeBytes and indexCacheSizeBytes.
-### Implementation a custom partition storage
+**To use Lance storage, configure:**
+
+```properties
+gravitino.stats.partition.storageFactoryClass=org.apache.gravitino.stats.storage.LancePartitionStatisticStorageFactory
Review Comment:
better to add space before and after `=`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
