jerqi commented on PR #9779:
URL: https://github.com/apache/gravitino/pull/9779#issuecomment-3827864251
Thanks for your work
1. Could u better create an issue and link this pull request? You can fill
the issue id in the section `Why are the changes needed`. You can use the words
`FIx #${issue-id}`, for example `Fix #9701 `
2. Could u add upgrade sql scripts, too? If we create a new table, we should
add the create sql in the upgrade `upgrade-1.1.0-to-1.2.0-xxx.sql`?
3. Could u use JdbcPartitionStorage as default partition storage? Because
entity store is configured as Jdbc entity store. You can reuse the properties
of entity store as the default value.
4. Left a minor. You can see the comment.
https://github.com/apache/gravitino/pull/9779#discussion_r2715603295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
