mchades commented on code in PR #11288:
URL: https://github.com/apache/gravitino/pull/11288#discussion_r3339056468
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveViewCatalogOperations.java:
##########
@@ -363,14 +369,17 @@ private HiveView toHiveView(
Maps.newHashMap(properties != null ? properties : ImmutableMap.of());
String representationSql = viewOriginalText;
String detectedDialect = HiveView.detectDialect(representationSql, params);
- if (!Dialects.HIVE.equalsIgnoreCase(detectedDialect)
- && !Dialects.FLINK.equalsIgnoreCase(detectedDialect)) {
- // TODO(design-docs/gravitino-logical-view-management.md): support
loading trino/spark HMS
- // views.
- throw new UnsupportedOperationException(
- String.format(
- "Hive catalog currently supports only '%s' and '%s' view
dialects, but found '%s' for view %s",
- Dialects.HIVE, Dialects.FLINK, detectedDialect, ident));
+ switch (detectedDialect.toLowerCase(java.util.Locale.ROOT)) {
Review Comment:
`java.util.Locale.ROOT` is a fully-qualified class name used inside a method
body, which violates the project coding style (AGENTS.md: prefer normal imports
over FQN). Please add `import java.util.Locale;` and replace all three
occurrences (lines 372, 420, 444) with `Locale.ROOT`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
