mchades commented on code in PR #11288:
URL: https://github.com/apache/gravitino/pull/11288#discussion_r3339337502
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/catalog/BaseCatalog.java:
##########
@@ -312,11 +315,22 @@ public boolean tableExists(Identifier ident) {
loadGravitinoTable(ident);
return true;
} catch (NoSuchTableException e) {
- return false;
+ // fall through to view check
Review Comment:
`tableExists()` now returns `true` for views as well as tables, but this
behavioral change is not reflected in the Javadoc. Please update it to document
that the method checks both tables and views.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
