mchades commented on code in PR #11288:
URL: https://github.com/apache/gravitino/pull/11288#discussion_r3339608759
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/catalog/BaseCatalog.java:
##########
@@ -312,11 +315,22 @@ public boolean tableExists(Identifier ident) {
loadGravitinoTable(ident);
return true;
} catch (NoSuchTableException e) {
- return false;
+ // fall through to view check
Review Comment:
Spark 3.4+ has a `ViewCatalog` interface
(`org.apache.spark.sql.connector.catalog.ViewCatalog` in `spark-catalyst`) that
enables `SHOW VIEWS`, `CREATE VIEW`, `DROP VIEW` etc. via Spark SQL. Since this
project already has version-specific subclasses (`GravitinoHiveCatalogSpark34`,
etc.) for Spark 3.4/3.5, it seems feasible to implement `ViewCatalog` there
without breaking 3.3 support. Is there a reason it is not included in this PR?
Should it be tracked as a follow-up?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
