diqiu50 commented on code in PR #11288:
URL: https://github.com/apache/gravitino/pull/11288#discussion_r3339955134
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveView.java:
##########
@@ -52,7 +52,9 @@
@ToString
public class HiveView implements View {
- private static final String SPARK_VERSION_KEY = "spark.sql.create.version";
+ static final String SPARK_VERSION_KEY = "spark.sql.create.version";
Review Comment:
SPARK_VERSION_KEY is used by HiveViewCatalogOperations
##########
spark-connector/spark-common/src/main/java/org/apache/gravitino/spark/connector/catalog/BaseCatalog.java:
##########
@@ -312,11 +315,22 @@ public boolean tableExists(Identifier ident) {
loadGravitinoTable(ident);
return true;
} catch (NoSuchTableException e) {
- return false;
+ // fall through to view check
Review Comment:
CREATE VIEW via SQL is not supported for V2 named catalogs. Spark's
ResolveSessionCatalog unconditionally throws for any non-session catalog
(see the "case CreateView(ResolvedIdentifier(catalog, _), ...)" branch),
regardless of
whether the catalog implements ViewCatalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
