mchades commented on code in PR #11288:
URL: https://github.com/apache/gravitino/pull/11288#discussion_r3339232946
##########
catalogs/catalog-hive/src/main/java/org/apache/gravitino/catalog/hive/HiveView.java:
##########
@@ -52,7 +52,9 @@
@ToString
public class HiveView implements View {
- private static final String SPARK_VERSION_KEY = "spark.sql.create.version";
+ static final String SPARK_VERSION_KEY = "spark.sql.create.version";
Review Comment:
`SPARK_VERSION_KEY` was widened from `private` to package-private, but no
other class in this PR references `HiveView.SPARK_VERSION_KEY`.
`SPARK_DEFAULT_CATALOG_KEY` and `SPARK_DEFAULT_SCHEMA_KEY` are correctly
package-private (they are referenced in `HiveViewCatalogOperations`), but
`SPARK_VERSION_KEY` is only used inside `HiveView` itself. Please revert it to
`private`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
