xushiyan commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1237029723
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -83,16 +86,20 @@ public WriteStatus() {
this.random = null;
}
+ public void markSuccess() {
+ totalRecords++;
Review Comment:
this was only used when `populateMetaFields` is false. but i think we should
track the same info regardless of that config. i'll check if any historical
reason for this as this was migrated over
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
