xushiyan commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1237507558


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -83,16 +86,20 @@ public WriteStatus() {
     this.random = null;
   }
 
+  public void markSuccess() {
+    totalRecords++;

Review Comment:
   so this was done in that way mainly due to hoodie key is not applicable when 
using spark bulkinsert row-writing without metafields. but to consolidate APIs 
and track more info like new location, we can just use the other api with dummy 
key



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to