xushiyan commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1237914169
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -52,9 +55,9 @@ public class WriteStatus implements Serializable {
private final HashMap<HoodieKey, Throwable> errors = new HashMap<>();
- private final List<HoodieRecord> writtenRecords = new ArrayList<>();
+ private final List<HoodieRecordDelegate> writtenRecordDelegates = new
ArrayList<>();
- private final List<HoodieRecord> failedRecords = new ArrayList<>();
+ private final List<Pair<HoodieRecordDelegate, Throwable>> failedRecords =
new ArrayList<>();
Review Comment:
we do check if write status has error, then only trace-log those errors
which only contain key info and exception. failed records are never used within
hudi. we should be ok leaving as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
