xushiyan commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1236980869
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/io/HoodieAppendHandle.java:
##########
@@ -484,7 +485,7 @@ protected void doWrite(HoodieRecord record, Schema schema,
TypedProperties props
} catch (Throwable t) {
// Not throwing exception from here, since we don't want to fail the
entire job
// for a single record
- writeStatus.markFailure(record, t, recordMetadata);
+ writeStatus.markFailure(lazily(() ->
HoodieRecordDelegate.fromHoodieRecord(record)), t, recordMetadata);
Review Comment:
in markSuccess and markFailure, there are conditions to be met for actually
tracking records. If conditions not met, we do not need to create delegate
objects. It's some minor saving for now given delegate is lean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
