lw309637554 commented on a change in pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#discussion_r452157405



##########
File path: hudi-sync/hudi-hive-sync/pom.xml
##########
@@ -43,6 +45,11 @@
       <artifactId>hudi-hadoop-mr</artifactId>
       <version>${project.version}</version>
     </dependency>
+    <dependency>
+      <groupId>org.apache.hudi</groupId>
+      <artifactId>hudi-sync-common</artifactId>

Review comment:
       Thanks, I thank put hudi-sync-common base class to hudi-common is make 
sense. but hudi-sync-hive 、hudi-sync-dla under hudi/     directory  will make 
hudi code so much moudle .  
   I think another choice to  put hudi-sync-common base class to hudi-common , 
and hudi-sync-hive 、hudi-sync-dla  etc.. under hudi-sync.
   what about yours suggestion @vinothchandar @leesf ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to