lw309637554 commented on a change in pull request #1810:
URL: https://github.com/apache/hudi/pull/1810#discussion_r452160698
##########
File path:
hudi-sync/hudi-hive-sync/src/main/java/org/apache/hudi/hive/HoodieHiveClient.java
##########
@@ -272,6 +268,7 @@ void createTable(String tableName, MessageType
storageSchema, String inputFormat
/**
* Get the table schema.
*/
+ //???? overwrite
Review comment:
agree with you. can put the abstract method getTableSchema to base
syncClient.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
