nsivabalan commented on code in PR #11266:
URL: https://github.com/apache/hudi/pull/11266#discussion_r1614726909
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -141,20 +141,20 @@ public class HoodieTableMetaClient implements
Serializable {
* Instantiate HoodieTableMetaClient.
* Can only be called if table already exists
*/
- protected HoodieTableMetaClient(StorageConfiguration<?> conf, String
basePath, boolean loadActiveTimelineOnLoad,
+ protected HoodieTableMetaClient(HoodieStorage storage, String basePath,
boolean loadActiveTimelineOnLoad,
Review Comment:
HoodieStorage is not serializable. and is marked as transient in
HoodieTableMetaClient.
accounting for this, are we good wrt changes in this patch?
if we pass HoodieTableMetaClient from driver to exe, how does exec
reconstruct the HoodieStorage?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -141,20 +141,20 @@ public class HoodieTableMetaClient implements
Serializable {
* Instantiate HoodieTableMetaClient.
* Can only be called if table already exists
*/
- protected HoodieTableMetaClient(StorageConfiguration<?> conf, String
basePath, boolean loadActiveTimelineOnLoad,
+ protected HoodieTableMetaClient(HoodieStorage storage, String basePath,
boolean loadActiveTimelineOnLoad,
Review Comment:
or in L153, should we try to call getStorage() just after
```
this.storage = storage;
```
bcoz, on driver this could be null right.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -244,7 +244,7 @@ public void
updateFunctionalIndexMetadata(HoodieFunctionalIndexMetadata newFunct
public static HoodieTableMetaClient reload(HoodieTableMetaClient
oldMetaClient) {
return HoodieTableMetaClient.builder()
- .setConf(oldMetaClient.storageConf.newInstance())
+ .setStorage(oldMetaClient.getStorage())
Review Comment:
don't we need a clone/create a new copy here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
