yihua commented on code in PR #11266:
URL: https://github.com/apache/hudi/pull/11266#discussion_r1614733935
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -141,20 +141,20 @@ public class HoodieTableMetaClient implements
Serializable {
* Instantiate HoodieTableMetaClient.
* Can only be called if table already exists
*/
- protected HoodieTableMetaClient(StorageConfiguration<?> conf, String
basePath, boolean loadActiveTimelineOnLoad,
+ protected HoodieTableMetaClient(HoodieStorage storage, String basePath,
boolean loadActiveTimelineOnLoad,
Review Comment:
Within this PR, we don't change the place where the meta client is
instantiated within the executor. `HoodieTableMetaClient` still holds the
`storageConf` instance which is serializable; so the meta client still has the
`storageConf` after deserialization on the executor (sent from driver), and the
`HoodieStorage` is instantiated first by leveraging the storage configuration,
i.e., `getStorage()` instantiates `this.storage` if it is null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
