nsivabalan commented on code in PR #11266:
URL: https://github.com/apache/hudi/pull/11266#discussion_r1614775416
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -161,7 +160,8 @@ protected AbstractHoodieLogRecordReader(HoodieStorage
storage, String basePath,
this.latestInstantTime = latestInstantTime;
this.hoodieTableMetaClient = hoodieTableMetaClientOption.orElseGet(
() -> HoodieTableMetaClient.builder()
-
.setConf(storage.getConf().newInstance()).setBasePath(basePath).build());
+ .setStorage(storage.newInstance(new StoragePath(basePath),
storage.getConf().newInstance()))
Review Comment:
we did have some mis-steps in creating new Path() in lot of places
unnecessarily which we later figured out while root causing perf issue. So,
just trying to be cautious here if we really wanted a new instance everytime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
