nsivabalan commented on code in PR #11266:
URL: https://github.com/apache/hudi/pull/11266#discussion_r1614727613


##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -141,20 +141,20 @@ public class HoodieTableMetaClient implements 
Serializable {
    * Instantiate HoodieTableMetaClient.
    * Can only be called if table already exists
    */
-  protected HoodieTableMetaClient(StorageConfiguration<?> conf, String 
basePath, boolean loadActiveTimelineOnLoad,
+  protected HoodieTableMetaClient(HoodieStorage storage, String basePath, 
boolean loadActiveTimelineOnLoad,

Review Comment:
   or in L153, should we try to call getStorage() just after 
   ```
   this.storage = storage;
   ```
   bcoz, on exec this could be null right. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to