nsivabalan commented on code in PR #11266:
URL: https://github.com/apache/hudi/pull/11266#discussion_r1614731186
##########
hudi-common/src/main/java/org/apache/hudi/common/table/HoodieTableMetaClient.java:
##########
@@ -141,20 +141,20 @@ public class HoodieTableMetaClient implements
Serializable {
* Instantiate HoodieTableMetaClient.
* Can only be called if table already exists
*/
- protected HoodieTableMetaClient(StorageConfiguration<?> conf, String
basePath, boolean loadActiveTimelineOnLoad,
+ protected HoodieTableMetaClient(HoodieStorage storage, String basePath,
boolean loadActiveTimelineOnLoad,
Review Comment:
may be we are leaving it lazy. when constructing for the first time in
executor, storage could be null. but later if getStorage() is invoked, it might
instantiate HoodieStorage.
just wanted to ensure my understanding is right and there are no gaps here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
