yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978307100
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanActionExecutor.java:
##########
@@ -232,12 +230,9 @@ private HoodieCleanMetadata runClean(HoodieTable<T, I, K,
O> table, HoodieInstan
this.txnManager.beginTransaction(Option.of(inflightInstant),
Option.empty());
}
writeTableMetadata(metadata, inflightInstant.requestedTime());
- table.getActiveTimeline().transitionCleanInflightToComplete(false,
- inflightInstant,
TimelineMetadataUtils.serializeCleanMetadata(metadata));
+ table.getActiveTimeline().transitionCleanInflightToComplete(false,
inflightInstant, Option.of(metadata));
LOG.info("Marked clean started on " + inflightInstant.requestedTime() +
" as complete");
return metadata;
- } catch (IOException e) {
- throw new HoodieIOException("Failed to clean up after commit", e);
Review Comment:
Should we still catch `HoodieIOException` here (which could be thrown by
`transitionStateToComplete`)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
