yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978331668
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestCleanActionExecutor.java:
##########
@@ -138,7 +138,7 @@ void testPartialCleanFailure(CleanFailureType failureType)
throws IOException {
when(activeTimeline.getCleanerTimeline()).thenReturn(cleanTimeline);
when(cleanTimeline.getInstants()).thenReturn(Collections.singletonList(cleanInstant));
when(activeTimeline.readCleanerPlan(cleanInstant)).thenReturn(cleanerPlan);
-
when(activeTimeline.readCleanerInfoAsBytes(cleanInstant)).thenReturn(TimelineMetadataUtils.serializeCleanerPlan(cleanerPlan));
+
when(activeTimeline.readCleanerInfoAsBytes(cleanInstant)).thenReturn(Option.of(convertMetadataToBytArray(cleanerPlan)));
Review Comment:
Is this method `activeTimeline.readCleanerInfoAsBytes` still used? Let's
create a follow-up JIRA ticket to clean up the usage on byte array related
handling in the `HoodieTimeline` and subclasses.
##########
hudi-common/pom.xml:
##########
@@ -354,6 +354,12 @@
<artifactId>tally-core</artifactId>
<version>${tally.version}</version>
</dependency>
+ <dependency>
+ <groupId>commons-io</groupId>
+ <artifactId>commons-io</artifactId>
+ <version>2.18.0</version>
+ <scope>test</scope>
+ </dependency>
Review Comment:
Is this still needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
