yihua commented on code in PR #12900:
URL: https://github.com/apache/hudi/pull/12900#discussion_r1978322059
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/common/table/timeline/TestArchivedTimelineV2.java:
##########
@@ -100,7 +101,7 @@ private void writeArchivedTimeline(int batchSize, long
startTs) throws Exception
String completionTime = String.valueOf(instantTimeTs + 10);
HoodieInstant instant =
INSTANT_GENERATOR.createNewInstant(HoodieInstant.State.COMPLETED, "commit",
instantTime, completionTime);
HoodieCommitMetadata metadata =
testTable.createCommitMetadata(instantTime, WriteOperationType.INSERT,
Arrays.asList("par1", "par2"), 10, false);
- byte[] serializedMetadata =
TimelineMetadataUtils.serializeCommitMetadata(metaClient.getCommitMetadataSerDe(),
metadata).get();
+ byte[] serializedMetadata = convertMetadataToBytArray(metadata);
Review Comment:
Should this util method still take a meta client instance as an argument to
consider different serialization (i.e., JSON vs Avro between V1 and V2 for
commit metadata)?
##########
hudi-client/hudi-client-common/src/test/java/org/apache/hudi/common/table/timeline/TestArchivedTimelineV2.java:
##########
@@ -100,7 +101,7 @@ private void writeArchivedTimeline(int batchSize, long
startTs) throws Exception
String completionTime = String.valueOf(instantTimeTs + 10);
HoodieInstant instant =
INSTANT_GENERATOR.createNewInstant(HoodieInstant.State.COMPLETED, "commit",
instantTime, completionTime);
HoodieCommitMetadata metadata =
testTable.createCommitMetadata(instantTime, WriteOperationType.INSERT,
Arrays.asList("par1", "par2"), 10, false);
- byte[] serializedMetadata =
TimelineMetadataUtils.serializeCommitMetadata(metaClient.getCommitMetadataSerDe(),
metadata).get();
+ byte[] serializedMetadata = convertMetadataToBytArray(metadata);
Review Comment:
```suggestion
byte[] serializedMetadata = convertMetadataToByteArray(metadata);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
