yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017694045
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/deltacommit/BaseSparkDeltaCommitActionExecutor.java:
##########
@@ -50,16 +53,27 @@ public abstract class BaseSparkDeltaCommitActionExecutor<T>
private SparkUpsertDeltaCommitPartitioner<T> mergeOnReadUpsertPartitioner;
public BaseSparkDeltaCommitActionExecutor(HoodieSparkEngineContext context,
HoodieWriteConfig config, HoodieTable table,
- String instantTime,
WriteOperationType operationType) {
+ String instantTime,
WriteOperationType operationType) {
this(context, config, table, instantTime, operationType, Option.empty());
}
public BaseSparkDeltaCommitActionExecutor(HoodieSparkEngineContext context,
HoodieWriteConfig config, HoodieTable table,
- String instantTime,
WriteOperationType operationType,
- Option<Map<String, String>>
extraMetadata) {
+ String instantTime,
WriteOperationType operationType,
+ Option<Map<String, String>>
extraMetadata) {
super(context, config, table, instantTime, operationType, extraMetadata);
}
+ @Override
+ protected HoodieCommitMetadata
appendMetadataForMissingFiles(HoodieCommitMetadata commitMetadata) throws
IOException {
+ if
(table.getMetaClient().getTableConfig().getTableVersion().greaterThanOrEquals(HoodieTableVersion.EIGHT))
{
+ // reconciliation not required for table version 8 and above.
+ return commitMetadata;
+ } else {
+ return CommitMetadataUtils.reconcileMetadataForMissingFiles(table,
getCommitActionType(), instantTime, commitMetadata,
Review Comment:
Similar here to see if we can use `WriteMarkers` to handle this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
