yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017718274
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableRollback.java:
##########
@@ -218,6 +235,8 @@ void testRollbackWithDeltaAndCompactionCommit(boolean
rollbackUsingMarkers, int
HoodieWriteConfig secondCfg =
getHoodieWriteConfigWithSmallFileHandlingOff(true);
secondCfg.setValue(HoodieTableConfig.VERSION,
String.valueOf(tableVersion));
secondCfg.setValue(HoodieWriteConfig.WRITE_TABLE_VERSION,
String.valueOf(tableVersion));
+ secondCfg.setValue(HoodieWriteConfig.TIMELINE_LAYOUT_VERSION_NUM,
timelineLayoutVersion);
+
Review Comment:
The timeline layout version is automatically set when setting the write
table version in the write config builder, so this change is unnecessary.
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableInsertUpdateDelete.java:
##########
@@ -442,8 +442,7 @@ public boolean preFileCreation(HoodieLogFile logFile) {
HoodieWriteMetadata<JavaRDD<WriteStatus>> compactionMetadata =
writeClient.compact(instantTime);
String extension = table.getBaseFileExtension();
Collection<List<HoodieWriteStat>> stats =
compactionMetadata.getCommitMetadata().get().getPartitionToWriteStats().values();
- assertEquals(numLogFiles,
stats.stream().flatMap(Collection::stream).filter(state ->
state.getPath().contains(extension)).count());
- assertEquals(numLogFiles,
stats.stream().mapToLong(Collection::size).sum());
Review Comment:
Reason of changing this? This is not related to log file marker.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
