yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017712196
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/TestHoodieMergeOnReadTable.java:
##########
@@ -541,7 +541,7 @@ public void testLogBlocksCountsAfterLogCompaction(boolean
populateMetaFields, St
@ParameterizedTest
@ValueSource(booleans = {true, false})
public void testMetadataStatsOnCommit(Boolean rollbackUsingMarkers) throws
Exception {
- HoodieWriteConfig cfg = getConfigBuilder(false, rollbackUsingMarkers,
IndexType.INMEMORY)
+ HoodieWriteConfig cfg = getConfigBuilder(false, rollbackUsingMarkers,
IndexType.BLOOM)
Review Comment:
Reason of changing to `BLOOM`?
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkCopyOnWriteTableRollbackTableVersionSix.java:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.hudi.table.functional;
+
+import org.junit.jupiter.api.Tag;
+import org.junit.jupiter.api.Test;
+
+import static org.apache.hudi.common.model.HoodieTableType.COPY_ON_WRITE;
+
+@Tag("functional")
+public class TestHoodieSparkCopyOnWriteTableRollbackTableVersionSix extends
TestHoodieSparkRollback {
Review Comment:
Could you report the time to run all the new tests added in this PR both
locally and in CI (search in the `Tests` tab shown below)?
<img width="1442" alt="Screenshot 2025-03-27 at 16 23 04"
src="https://github.com/user-attachments/assets/d6446b75-bd80-488b-9ac2-fde97a1fbfd6";
/>
##########
hudi-spark-datasource/hudi-spark/src/test/java/org/apache/hudi/table/functional/TestHoodieSparkMergeOnReadTableCompaction.java:
##########
@@ -200,11 +221,190 @@ public void testWriteLogDuringCompaction(boolean
enableMetadataTable, boolean en
client.delete(deleteRecords, client.startCommit());
// insert the same 100 records again
client.upsert(writeRecords, client.startCommit());
- Assertions.assertEquals(100, readTableTotalRecordsNum());
+ assertEquals(100, readTableTotalRecordsNum());
} finally {
jsc().hadoopConfiguration().set(HoodieReaderConfig.FILE_GROUP_READER_ENABLED.key(),
"true");
}
+ }
+
+ @ParameterizedTest
+ @CsvSource(value = {"true,true", "true,false", "false,true", "false,false"})
+ void testCompactionSchedulingWithUncommittedLogFileOrRollback(boolean
enableMetadataTable,
Review Comment:
Could you explain the particular logic this test covers? And is it possible
to add a unit test instead of the functional test here? Same on reporting the
test time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
