yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017703585
##########
hudi-common/src/main/java/org/apache/hudi/common/table/marker/MarkerOperation.java:
##########
@@ -34,6 +34,7 @@ public class MarkerOperation implements Serializable {
// GET requests
public static final String ALL_MARKERS_URL = String.format("%s/%s",
BASE_URL, "all");
public static final String CREATE_AND_MERGE_MARKERS_URL =
String.format("%s/%s", BASE_URL, "create-and-merge");
+ public static final String APPEND_MARKERS_URL = String.format("%s/%s",
BASE_URL, "append");
Review Comment:
Mark this v6 only with Javadocs.
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1089,35 +1089,6 @@ public static Set<String> getRecordKeys(List<String>
logFilePaths, HoodieTableMe
return Collections.emptySet();
}
- private static void reAddLogFilesFromRollbackPlan(HoodieTableMetaClient
dataTableMetaClient, String instantTime,
- Map<String, Map<String,
Long>> partitionToFilesMap) {
- InstantGenerator factory = dataTableMetaClient.getInstantGenerator();
Review Comment:
Is this logic move to another place?
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -291,6 +292,63 @@ public static Map<String, List<StoragePathInfo>>
getFilesInPartitions(HoodieEngi
}
}
+ /**
+ * Get all the files in the given partition path.
+ *
+ * @param storage Hoodie Storage
+ * @param partitionPathIncludeBasePath The full partition path including the
base path
+ * @param filesNamesUnderThisPartition The names of the files under this
partition for which file status is needed
+ * @param ignoreMissingFiles If true, missing files will be ignored and
empty Option will be added to the result list
+ * @return List of file statuses for the files under this partition
+ */
+ public static List<Option<StoragePathInfo>>
getPathInfoUnderPartition(HoodieStorage storage,
Review Comment:
If this should only be used by listing the log files, move this method to
the corresponding class using this and make it private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
