yihua commented on code in PR #13007:
URL: https://github.com/apache/hudi/pull/13007#discussion_r2017700535
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestMarkerBasedRollbackStrategy.java:
##########
@@ -149,6 +163,65 @@ public void
testMarkerBasedRollbackAppendWithLogFileMarkers(IOType testIOType) t
assertEquals(testIOType.equals(IOType.CREATE) ? 0 : 1,
rollbackRequest.getLogBlocksToBeDeleted().size());
}
+ @ParameterizedTest
+ @CsvSource(value = {"APPEND,true,true", "APPEND,true,false",
"APPEND,false,true", "APPEND,false,false"})
+ public void
testMarkerBasedRollbackAppendWithLogFileMarkersTableVersionSix(IOType
testIOType,
Review Comment:
Modify
`TestMarkerBasedRollbackStrategy#testGetRollbackRequestsWithMultipleLogFilesInOneFileGroup`
to account for the new logic instead of adding this test?
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/table/functional/TestMarkerBasedRollbackStrategy.java:
##########
@@ -165,10 +238,11 @@ public void testCopyOnWriteRollbackWithTestTable() throws
Exception {
.withMarkerFile("partA", f2, IOType.CREATE);
// when
- HoodieTable hoodieTable = HoodieSparkTable.create(getConfig(), context,
metaClient);
+ HoodieTable hoodieTable =
HoodieSparkTable.create(getConfigBuilder().withEmbeddedTimelineServerEnabled(false).build(),
context, metaClient);
Review Comment:
Remove all `.withEmbeddedTimelineServerEnabled(false)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
