nsivabalan commented on PR #13007: URL: https://github.com/apache/hudi/pull/13007#issuecomment-2760166889
Major refactoring changes updated: - Introduced CommitMetadataResolver which BaseHoodieWriteClient calls to prepare the commit metadata. All logic to build commit metadata and then calling reconcile based on table version is all hidden inside this class. - Moved the logic to choose the right IO type based on table version is moved into WriteMarkers class. So that HoodieWriteHandle does not need to have code snippets based on table version - Renamed BaseRollbackHelper -> RollbackHelper and BaseRollbackHelperForTableVersionSix to BaseRollbackHelper. Introduced RollbackHelperFactory to return an instance of RollbackHelper over which, BaseRollbackActionExecutor can invoke performRollback ``` RollbackHelperFactory.getRollBackHelper(table, config).performRollback(context, instantTime, instantToRollback, rollbackPlan.getRollbackRequests()); ``` Again, rollback action executor does not need to have code snippets based on diff table versions. few other minor fixes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
