the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2128960498
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/procedures/ShowColumnStatsOverlapProcedure.scala:
##########
@@ -262,7 +263,7 @@ class ShowColumnStatsOverlapProcedure extends BaseProcedure
with ProcedureBuilde
val timeline =
metaClient.getActiveTimeline.getCommitsTimeline.filterCompletedInstants()
- val maxInstant = metaClient.createNewInstantTime()
+ val maxInstant = HoodieInstantTimeGenerator.getCurrentTimeAsString
Review Comment:
The change is really around the intentionality of the code. In this case we
just want the current time as a string to represent a boundary.
`createNewInstantTime` methods are more like a "request new transaction ID"
which comes with some overhead (compares against last generated instant, sleeps
for 1ms) that is not required here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
