the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2129973131
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -341,22 +340,26 @@ private void saveInternalSchema(HoodieTable table, String
instantTime, HoodieCom
}
protected HoodieTable createTableAndValidate(HoodieWriteConfig writeConfig,
- BiFunction<HoodieWriteConfig,
HoodieEngineContext, HoodieTable> createTableFn) {
- HoodieTable table = createTableFn.apply(writeConfig, context);
+ TableCreator createTableFn) {
+ HoodieTable table = createTableFn.apply(writeConfig, context, txnManager);
CommonClientUtils.validateTableVersion(table.getMetaClient().getTableConfig(),
writeConfig);
return table;
}
@FunctionalInterface
- protected interface TriFunction<T, U, V, R> {
- R apply(T t, U u, V v);
+ protected interface TableCreator {
+ HoodieTable apply(HoodieWriteConfig writeConfig, HoodieEngineContext
context, TransactionManager transactionManager);
+ }
+
+ @FunctionalInterface
+ protected interface TableCreatorWithMetaClient {
+ HoodieTable apply(HoodieWriteConfig writeConfig, HoodieEngineContext
context, HoodieTableMetaClient metaClient, TransactionManager
transactionManager);
Review Comment:
This is no longer used, marking as resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
