the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2129022805
##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/TestPartitionTTLManagement.java:
##########
@@ -95,10 +102,8 @@ public void testKeepByCreationTime() {
String partitionPath2 = dataGen.getPartitionPaths()[2];
writeRecordsForPartition(client, dataGen, partitionPath2,
currentInstant);
- String instantTime = client.createNewInstantTime();
+ String instantTime =
client.startCommit(HoodieTimeline.REPLACE_COMMIT_ACTION);
Review Comment:
This is the pattern already in use by the
[HoodieSparkSqlWriter](https://github.com/apache/hudi/blob/master/hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala#L447-L448)
so that will need to be updated as well I guess
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
