the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2129921949
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/util/CompactionUtil.java:
##########
@@ -189,11 +192,13 @@ public static void
rollbackEarliestCompaction(HoodieFlinkTable<?> table, Configu
instant.getState() == HoodieInstant.State.INFLIGHT).firstInstant();
if (earliestInflight.isPresent()) {
HoodieInstant instant = earliestInflight.get();
- String currentTime = table.getMetaClient().createNewInstantTime();
Review Comment:
It is about the intention of the code. `createNewInstantTime` methods are
meant to be used in the context of creating a new transaction ID. It has some
more overhead than simply generating the time as a string.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
