the-other-tim-brown commented on code in PR #13380:
URL: https://github.com/apache/hudi/pull/13380#discussion_r2129002668
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieTableServiceClient.java:
##########
@@ -621,7 +621,14 @@ protected void runTableServicesInline(HoodieTable table,
HoodieCommitMetadata me
// Do an inline partition ttl management if enabled
if (config.isInlinePartitionTTLEnable()) {
- String instantTime = createNewInstantTime();
+ txnManager.beginStateChange(Option.empty(), Option.empty());
+ String instantTime;
+ try {
+ instantTime = createNewInstantTime(false);
+
table.getMetaClient().getActiveTimeline().createRequestedCommitWithReplaceMetadata(instantTime,
HoodieTimeline.REPLACE_COMMIT_ACTION);
Review Comment:
Even in the current code, the replaced file IDs are empty in the requested
instant.
https://github.com/apache/hudi/blob/master/hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkDeletePartitionCommitActionExecutor.java#L83
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
