rangareddy commented on code in PR #19433:
URL: https://github.com/apache/hudi/pull/19433#discussion_r3690170667
##########
packaging/hudi-presto-bundle/pom.xml:
##########
@@ -141,7 +141,7 @@
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Done in ed3ccf5 — `hudi-hadoop-mr` and `hudi-hadoop-common` are now declared
directly here, with a comment explaining that they are shade inputs and should
not arrive via another bundle's published dependency list.
Verified with the recipe from your other comment (install the reduced
`hudi-hadoop-mr-bundle` POM, then `mvn package -pl
packaging/hudi-presto-bundle` with no `-am`): 109 `org/apache/hudi/hadoop/**`
entries, `HoodieParquetInputFormat.class` included.
On the remaining `hudi-hadoop-mr-bundle` dependency: agreed it is odd for
this bundle to declare a fat jar that duplicates classes it already shades, and
agreed it is pre-existing. With `promoteTransitiveDependencies=true` the
reduced POM is no longer just that one entry, but the fat-jar dependency itself
is still there. Dropping it needs checking what else it is currently supplying
to the presto shade inputs, so I have left it alone here rather than widen this
PR — happy to pick it up separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
