rangareddy commented on code in PR #19433:
URL: https://github.com/apache/hudi/pull/19433#discussion_r3690173840
##########
packaging/hudi-aws-bundle/pom.xml:
##########
@@ -117,7 +117,7 @@
<shadedPattern>org.apache.hudi.aws.org.apache.httpcomponents.</shadedPattern>
Review Comment:
You are right, thank you — `org.apache.httpcomponents` is the groupId and
the classes are `org.apache.http.*`, so that relocation entry matches nothing
and my description cited it as if it were the mechanism. I have corrected the
PR description: the relocation that actually applies is the inherited root rule
`org.apache.http.` -> `org.apache.hudi.org.apache.http.`, merged in via
`<relocations combine.children="append">`.
Confirmed the same thing in the built jar you checked — everything under
`org/apache/hudi/org/apache/http/`, nothing unrelocated and nothing under
`org/apache/hudi/aws/`.
Left the dead relocation entry alone so this PR stays about the published
POMs. Happy to remove it in a follow-up, or here if you would prefer it cleaned
up in one go.
##########
packaging/hudi-hive-sync-bundle/pom.xml:
##########
@@ -123,7 +123,7 @@
<shadedPattern>org.apache.hudi.org.objenesis.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Thanks — the transitive-drop point is addressed for this bundle too:
`promoteTransitiveDependencies=true` is now set on all seven, so
`hudi-hive-sync-bundle`'s reduced POM keeps the dependencies that are not
absorbed into the shaded jar rather than dropping them with the removed entry.
Details and the numbers are in my reply on the `hudi-aws-bundle` thread,
including a correction about which hadoop/hive artifacts were actually in the
closure.
##########
packaging/hudi-gcp-bundle/pom.xml:
##########
@@ -115,7 +115,7 @@
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Thanks — the transitive-drop point is addressed for this bundle too:
`promoteTransitiveDependencies=true` is now set on all seven, so
`hudi-gcp-bundle`'s reduced POM keeps the dependencies that are not absorbed
into the shaded jar rather than dropping them with the removed entry. Details
and the numbers are in my reply on the `hudi-aws-bundle` thread, including a
correction about which hadoop/hive artifacts were actually in the closure.
##########
packaging/hudi-azure-bundle/pom.xml:
##########
@@ -132,7 +132,7 @@
<shadedPattern>org.apache.hudi.org.reactivestreams.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Thanks — the transitive-drop point is addressed for this bundle too:
`promoteTransitiveDependencies=true` is now set on all seven, so
`hudi-azure-bundle`'s reduced POM keeps the dependencies that are not absorbed
into the shaded jar rather than dropping them with the removed entry. Details
and the numbers are in my reply on the `hudi-aws-bundle` thread, including a
correction about which hadoop/hive artifacts were actually in the closure.
##########
packaging/hudi-datahub-sync-bundle/pom.xml:
##########
@@ -91,7 +91,7 @@
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Thanks — the transitive-drop point is addressed for this bundle too:
`promoteTransitiveDependencies=true` is now set on all seven, so
`hudi-datahub-sync-bundle`'s reduced POM keeps the dependencies that are not
absorbed into the shaded jar rather than dropping them with the removed entry.
Details and the numbers are in my reply on the `hudi-aws-bundle` thread,
including a correction about which hadoop/hive artifacts were actually in the
closure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
