rangareddy commented on code in PR #19433:
URL: https://github.com/apache/hudi/pull/19433#discussion_r3691823316
##########
packaging/hudi-aws-bundle/pom.xml:
##########
@@ -117,7 +117,7 @@
<shadedPattern>org.apache.hudi.aws.org.apache.httpcomponents.</shadedPattern>
</relocation>
</relocations>
-
<createDependencyReducedPom>false</createDependencyReducedPom>
+
<createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
One more thing I found on a re-check, worth your call before this merges.
Nine other bundles already publish a reduced POM and **none** of them sets
`promoteTransitiveDependencies`: `hudi-spark-bundle`, `hudi-utilities-bundle`,
`hudi-utilities-slim-bundle`, `hudi-flink-bundle`, `hudi-cli-bundle`,
`hudi-kafka-connect-bundle`, `hudi-integ-test-bundle`,
`hudi-metaserver-server-bundle` (shade's default) and
`hudi-timeline-server-bundle` (explicit `true`).
`hudi-spark3.5-bundle_2.12`'s published POM has carried **8** dependencies
from 0.15.0 through current master, so dropping non-bundled transitives is the
shipped behaviour for those nine. With promotion the seven here publish 73-191
instead. So the real choice is promotion everywhere or promotion nowhere, and
right now this PR makes seven differ from nine.
I have kept promotion because it preserves the runtime contract you raised
and is the conservative direction for consumers, but I did not want to decide
house style silently. Either is a small change from here: drop it and document
the transitive drop instead, or keep it and align the other nine in a
follow-up. I left those nine alone deliberately, since touching them changes
published metadata for nine more artifacts including the Spark and Flink
bundles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
