voonhous commented on code in PR #19433:
URL: https://github.com/apache/hudi/pull/19433#discussion_r3694767642
##########
packaging/hudi-datahub-sync-bundle/pom.xml:
##########
@@ -91,7 +91,7 @@
<shadedPattern>org.apache.hudi.org.openjdk.jol.</shadedPattern>
</relocation>
</relocations>
- <createDependencyReducedPom>false</createDependencyReducedPom>
+ <createDependencyReducedPom>true</createDependencyReducedPom>
Review Comment:
Two corrections after rebuilding `ed3ccf5`, neither blocking.
**1. `parquet-avro` and `avro` no longer survive the reduction.** That held
for `73d9d06`, but not after promotion was added. Shade runs at
`requiresDependencyResolution=runtime`, so `project.getArtifacts()` is
compile+runtime only, and with `promoteTransitiveDependencies=true` that set
*replaces* the original direct-dependency list rather than filtering it, so
`provided` entries are dropped. On the built POM:
```
packaging/hudi-datahub-sync-bundle/target/dependency-reduced-pom.xml
parquet-avro : absent
avro : absent
```
Consumer impact is nil, since `provided` is not transitive, and this is the
only one of the seven that declares any `provided` deps. So it is a description
fix, not a code fix.
**2. The reduced POM declares `hudi-hadoop-mr:compile`**, and that artifact
depends on `hudi-common` and `hudi-hadoop-common`, both of which are in this
bundle's artifactSet. The absorbed artifacts come back one hop down. Not a
regression, since today's POM declares `hudi-common` directly anyway, just an
incomplete win worth knowing about.
**Action:** description only. Drop the "already provided so they survive"
reasoning and note the `provided` drop instead. No POM change needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
