voonhous commented on PR #19433: URL: https://github.com/apache/hudi/pull/19433#issuecomment-5150113131
Re-reviewed `ed3ccf5` against a clean build of both refs rather than the POMs alone. **Both blocking items are genuinely fixed**, and I have resolved the six threads that need nothing further. The presto fix in particular is structural, not incidental: declaring `hudi-hadoop-mr` and `hudi-hadoop-common` directly means this bundle's shade inputs no longer depend on another bundle's published dependency list at all. Jar listing is identical to master, 109 `org/apache/hudi/hadoop/**` entries, `HoodieParquetInputFormat` present. Remaining action items, none of which need a new commit except the description edits: **This PR:** - [ ] Impact: promotion flattens the graph, so the 80-190 promoted artifacts become depth-1 for consumers with pinned versions and baked-in exclusions. Details in the `hudi-aws-bundle` thread. - [ ] Impact: `hudi-datahub-sync-bundle` now drops its two `provided` deps (`parquet-avro`, `avro`). Harmless to consumers, but the reasoning currently on that thread no longer matches the code. Details in the `hudi-datahub-sync-bundle` thread. - [ ] Release note for the seven bundles, as you already flagged. **Follow-ups, please file rather than fix here:** - [ ] presto coverage in `packaging/bundle-validation`. Yes, worth filing, and worth stating why in the issue: every `-pl packaging/...` in `.github/workflows` and `scripts/` passes `-am`, so the green Azure run on this PR could not have caught the regression this PR fixes. - [ ] dead relocation entry `org.apache.httpcomponents.` -> `org.apache.hudi.aws.org.apache.httpcomponents.` in `hudi-aws-bundle`. - [ ] `hudi-presto-bundle` declaring `hudi-hadoop-mr-bundle`, a fat jar duplicating classes it already shades. - [ ] promotion on the other nine bundles, or an explicit decision to leave them as they are. Open question on promotion is answered in the `hudi-aws-bundle` thread: **keep it on these seven**. Two things worth crediting: your correction that the `hadoop-*` / `hive-*` artifacts are `provided` in the root `dependencyManagement` and therefore never propagated is right, and my example on that thread was wrong. And thanks for running the install-then-resolve recipe properly instead of taking the in-reactor build at face value, which is exactly what hid this in the first place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
