n3nash commented on a change in pull request #3025:
URL: https://github.com/apache/hudi/pull/3025#discussion_r651297449
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java
##########
@@ -63,7 +63,7 @@ public
BaseScheduleCompactionActionExecutor(HoodieEngineContext context,
+ ", Compaction scheduled at " + instantTime));
// Committed and pending compaction instants should have strictly lower
timestamps
List<HoodieInstant> conflictingInstants = table.getActiveTimeline()
- .getWriteTimeline().getInstants()
+
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstants()
Review comment:
@swuferhong @danny0405 If you take a look at the previous version of
this file, the method is called before was `commitsAndCompactionTimeline` ->
https://github.com/apache/hudi/blob/3e71c915271d77c7306ca0325b212f71ce723fc0/hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java#L110
This follows the same behavior as getWriteTimeline().getInstants(). Can you
please explain what is a possible bug here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
