danny0405 commented on a change in pull request #3025:
URL: https://github.com/apache/hudi/pull/3025#discussion_r652258797



##########
File path: 
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/compact/BaseScheduleCompactionActionExecutor.java
##########
@@ -63,7 +63,7 @@ public 
BaseScheduleCompactionActionExecutor(HoodieEngineContext context,
                   + ", Compaction scheduled at " + instantTime));
       // Committed and pending compaction instants should have strictly lower 
timestamps
       List<HoodieInstant> conflictingInstants = table.getActiveTimeline()
-          .getWriteTimeline().getInstants()
+          
.getWriteTimeline().filterCompletedAndCompactionInstants().getInstants()

Review comment:
       Sure, let us add a test case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to